[meego-commits] 6804: Changes to Tools:Building/osc

[Jian-feng Ding]

On Thu, Aug 19, 2010 at 07:53:01PM +0800, Alexander Kanevskiy wrote:
> On Thu, Aug 19, 2010 at 12:40, Jian-feng Ding <jian-feng.ding at intel.com> wrote:
> > On Thu, Aug 19, 2010 at 05:15:29PM +0800, Alexander Kanevskiy wrote:
> >> On Thu, Aug 19, 2010 at 12:12, Jian-feng Ding <jian-feng.ding at intel.com> wrote:
> >> >> > in this chunk, if memory serves me well, --target argument of "build"
> >> >> > would be directly passed to rpmbuild.
> >> >> > For ARM setup of OBS it means it will be passing "armv7el" or
> >> >> > "armv5el" as parameter, and those strings can't be reconginzed by RPM,
> >> >> > as they are OBS specifics.  Have you at all tested "osc build " after
> >> >> > that change with arm pacakges ?
> >> >> Sorry, not tested with arm packages yet, but I'll do it at once, thanks for your reminding.
> >> >
> >> > Tried to local build arm packages, but blocked by many issues.
> >> > As Austin Zhang told me, it need many extra packages from openSUSE.org and being installed
> >> > manually.
> >>
> >> it requires only setup of qemu. Works perfectly on my fedora box.
> > Yes, just the "setup" should be standardized with meego packages.
> 
> 
> >> > It seems there's a long way to make it work, so I suggest we support arm packages' local building later.
> >>
> >> No. Do not break that is working already.
> > Is it right to do not break that by doing nothing here ?
> 
> we're speaking about one particular hunk in your patch, which is
> 1. not in upstream
> 2. introduces problem
> 
> 
> >> PS. Actually I do not understand, why we have local patches to OSC
> >> which touches something else than configuration files ? Those should
> >> be submitted to upstream first.
> > Actually, this patch is a very old one which was already integrated into current meego released osc. If
> > current meego osc can work with arm packages' local building, I think we need not to modify it at present.
> > Right?
> 
> Actually not. It was lucky coincidence for me, that it worked, as I
> had osc installed from openSuSE (which is often has newer version than
> in MeeGo tools repo).
Oh, if so, I will modify the patch to make it workable with arm packages.

BTW, most of the integrated patches in meego released osc are meego specific, and
will not go to upstream.
> 
> -- 
> br, Alexander Kanevskiy