[meego-commits] 6887: Changes to Trunk:Netbook/cheese

[Zhang, Qiang Z]

>-----Original Message-----
>From: Damien Lespiau [mailto:damien.lespiau at intel.com]
>Sent: 2010年8月23日 18:28
>To: meego-packaging at meego.com; Zhang, Qiang Z
>Cc: meego-commits at meego.com
>Subject: Re: [meego-commits] 6887: Changes to Trunk:Netbook/cheese
>
>On Sun, 2010-08-22 at 00:55 +0100, Zhang Qiang wrote:
>> ++++++ 0009-fix-url-error.patch (new)
>> --- 0009-fix-url-error.patch
>> +++ 0009-fix-url-error.patch
>> +diff -uNr cheese-2.30.0/src/cheese-commands-help.c
>cheese-2.30.0.new/src/cheese-commands-help.c
>> +--- cheese-2.30.0/src/cheese-commands-help.c	2010-02-10
>16:32:04.000000000 +0800
>> ++++ cheese-2.30.0.new/src/cheese-commands-help.c	2010-08-12
>18:49:50.933510382 +0800
>> +@@ -105,7 +105,7 @@
>> +        "MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the "
>> +        "GNU General Public License for more details.\n"),
>> +     N_("You should have received a copy of the GNU General Public License
>"
>> +-       "along with this program. If not, see
><http://www.gnu.org/licenses/>.")
>> ++       "along with this program. If not, see
>http://www.gnu.org/licenses/.")
>> +   };
>> +
>> +   char *license_trans;
>
>That looks like an interesting patch to submit upstream. Have you filed
>a bug in Cheese's bugzilla (I can't see a reference in the diff) ?
>https://bugzilla.gnome.org/enter_bug.cgi?product=cheese
>
[Zhang, Qiang] Thanks for your suggestion, a new bug in bugzilla.gnome.org is opened: https://bugzilla.gnome.org/show_bug.cgi?id=627790, and refined patch attached.

-Thanks
-Qiang

>As always, having more context in the patch itself or, at least, a
>comment in the yaml/spec file is a good idea (MeeGo bug#, bug# upstream
>if applicable, ...).
>
>--
>Damien