[meego-commits] 5329: Changes to Trunk/rdesktop

[Arjan van de Ven]

On 7/4/2010 7:53 AM, David Woodhouse wrote:
> Hi,
> The content of the spec file, rdesktop.spec:
> ===================================================================
> Name:           rdesktop
> Version:        1.6.0
> Release:        7%{?dist}
>    

don't know where you got the spec from, but we don't have/use %{?dist}


> Summary:        X client for remote desktop into Windows Terminal Server
>
> Group:          User Interface/Desktops
> License:        GPLv2+
> URL:            http://www.rdesktop.org/
> Source0:        %{name}-%{version}.tar.gz
> BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
> BuildRequires:  openssl-devel, libX11-devel
>    

please use pkgconfig() for BuildRequires


> %{_mandir}/man1/*
>    

this ought to be %doc as well, right ?