[meego-commits] 5450: Changes to Trunk:Testing/firstboot

[Anas Nashif]

Hi,
I have made the following changes to firstboot in project Trunk:Testing. Please review and accept ASAP.

Thank You,
Anas Nashif

[This message was auto-generated]

---

Request #5450:

  submit:   home:nashif:branches:Trunk:Testing/firstboot(r3)(cleanup) -> Trunk:Testing/firstboot


Message:
    * Thu Jul 08 2010 Anas Nashif <anas.nashif at intel.com> - 1.0
- Remove cracklib dependency
- Dont use cracklib module for checking user passwords

State:   new          2010-07-08T13:03:29 nashif
Comment: None



changes files:
--------------
--- firstboot.changes
+++ firstboot.changes
@@ -0,0 +1,4 @@
+* Thu Jul 08 2010 Anas Nashif <anas.nashif at intel.com> - 1.0
+- Remove cracklib dependency
+- Dont use cracklib module for checking user passwords
+

new:
----
  remove_cracklib.patch

spec files:
-----------
--- firstboot.spec
+++ firstboot.spec
@@ -6,6 +6,7 @@
 Version: 1.0
 Release: 1
 Source0: %{name}-%{version}.tar.bz2
+Patch0: remove_cracklib.patch
 License: GPLv2+
 Group: System/Base
 ExclusiveOS: Linux
@@ -14,7 +15,6 @@
 BuildRequires: python-devel, python-setuptools-devel
 BuildRequires: gtk2-devel
 Requires: pygtk2, python
-Requires: cracklib-python
 Requires: libuser-python, system-config-date
 Requires: ecryptfs-utils
 Requires(post): chkconfig
@@ -27,6 +27,7 @@
 
 %prep
 %setup -q
+%patch0 -p1
 
 %build
 

other changes:
--------------

++++++ remove_cracklib.patch (new)
--- remove_cracklib.patch
+++ remove_cracklib.patch
+--- a/modules/create_user.py
++++ b/modules/create_user.py
+@@ -22,7 +22,6 @@ import libuser
+ import os, string, sys, time
+ import os.path
+ import users
+-import cracklib
+ import subprocess
+ import logging
+ import re
+@@ -227,22 +226,6 @@ class moduleClass(Module):
+                                          "not allowed."))
+                 return False
+ 
+-        try:
+-            cracklib.FascistCheck(password)
+-        except ValueError, e:
+-            msg = gettext.ldgettext("cracklib", e)
+-            dlg = gtk.MessageDialog(None, 0, gtk.MESSAGE_WARNING, gtk.BUTTONS_YES_NO,
+-                                   _("Weak password provided: %s"
+-                                     "\n\n"
+-                                     "Would you like to continue with "
+-                                     "this password?") % (msg, ))
+-            dlg.set_position(gtk.WIN_POS_CENTER)
+-            dlg.set_modal(True)
+-            addFrame(dlg, showtitle = 0)
+-            rc = dlg.run()
+-            dlg.destroy()
+-            if rc == gtk.RESPONSE_NO:
+-                return False
+         return True
+ 
+     def apply(self, interface, testing=False):