[meego-commits] 5493 declined: home:yyin2:branches:Trunk:Testing/pm-utils to Trunk:Testing/pm-utils

[Yin, Yan]

The pm-quirks-20100316.tar.gz is already in the package. :-)

The main changes between 1.3.x and 1.4.x series are those new powersave hooks, I'll recommend to upgrade to this release as it provides fine-grained power control for components including audio, hard drive, wireless, Ethernet, sata, etc, so that the power conversation when on battery can be lower.
However, as this package is rather new and it impacts system basic functions, I'd like to know more suggestions on this. Thanks in advance!

BTW, Arjan, I see below lines in the pm-utils.changes file from you, could you please help me understand why sched powersave is dropped for MeeGo?
* Tue Mar 23 2010 Arjan van de Ven <arjan at linux.intel.com> 1.3.0_rc3
- don't ship the sched powersave script; we don't want to have that one.

BTW: new powersave hooks in 1.4.x
        sched-powersave         \   // exist since 1.3.x
        harddrive               \
        laptop-mode             \
        xfs_buffer              \
        readahead               \
        intel-audio-powersave   \
        wireless                \
        journal-commit          \
        disable_wol             \
        pcie_aspm               \
        sata_alpm               \
        hal-cd-polling


Regards,
Yan

> -----Original Message-----
> From: Peter Zhu [mailto:peter.j.zhu at intel.com]
> Sent: Friday, July 09, 2010 9:12 PM
> To: Yin, Yan
> Cc: meego-commits at meego.com
> Subject: 5493 declined: home:yyin2:branches:Trunk:Testing/pm-utils to
> Trunk:Testing/pm-utils
> 
> Hi Yan Yin,
> The following change has been rejected.
> 
> Reason:  We don't need import-fdi-quirkdb.patch at all; please patch
> http://pm-utils.freedesktop.org/releases/pm-quirks-20100316.tar.gz; also
> please think twice if we need powersave feature in 1.4.X release, maybe better
> choice is 1.3.1
> 
> Please fix the issues above and resubmit.
> 
> Thanks,
> MeeGo Release Engineering Team
> 
> [This message was auto-generated]
> ---
> Request #5493:
> 
>   submit:   home:yyin2:branches:Trunk:Testing/pm-utils(r3)(cleanup) ->
> Trunk:Testing/pm-utils
> 
> 
> Message:
>     upgrade to 1.4.1, change to YAML
> 
> State:   declined     2010-07-09T01:07:32 peter
> Comment: We don't need import-fdi-quirkdb.patch at all; please patch
> http://pm-utils.freedesktop.org/releases/pm-quirks-20100316.tar.gz; also
> please think twice if we need powersave feature in 1.4.X release, maybe better
> choice is 1.3.1
> 
> 
> History: new          2010-07-08T15:59:07 yyin2