[meego-commits] 6042: Changes to Trunk:Testing/wpa_supplicant

[Jian-feng Ding]

On Wed, Jul 28, 2010 at 07:44:49PM +0800, Zhu, Peter J wrote:
> >  %build
> > +# >> build pre
> >  pushd wpa_supplicant
> > -  cp %{SOURCE1} ./.config
> > -  CFLAGS="${CFLAGS:-%optflags}" ; export CFLAGS ;
> > -  CXXFLAGS="${CXXFLAGS:-%optflags}" ; export CXXFLAGS ;
> > -  make %{_smp_mflags}
> > -popd
> > +cp %{SOURCE1} ./.config
> > +CFLAGS="${CFLAGS:-%optflags}" ; export CFLAGS ;
> > +CXXFLAGS="${CXXFLAGS:-%optflags}" ; export CXXFLAGS ;
> > +# << build pre
> >
> > +
> > +make %{?jobs:-j%jobs}
> > +
> > +# >> build post
> > +popd
> > +# << build post
> >  %install
> >  rm -rf %{buildroot}
> > +# >> install pre
> > +# << install pre
> > +
> Where is %make_install??

It will be better if the Makefile of this package can support `make install` target.
Otherwise we need customized installation scripts, the common handling method with spectacle is:
 1. set "Builder: none" (then no auto generated "make %{?jobs:-j%jobs}" too)
 2. insert "make %{?jobs:-j%jobs}" in proper place in "build post" closure

As this package, I recommend to move all build script from "build pre" to  "build post", if "builder" must be none.

> 
> > +# >> install post
> > +rm -rf %{buildroot}
> It should be removed. It's already covered by pieces emitted by specify.
> 
> >
> >  # binary
> >  install -d %{buildroot}/sbin
> > @@ -57,10 +88,16 @@
> >  rm -f  %{name}/doc/.cvsignore
> >  rm -rf %{name}/doc/docbook
> >