[meego-commits] 6042: Changes to Trunk:Testing/wpa_supplicant

[Jian-feng Ding]

On Wed, Jul 28, 2010 at 08:16:32PM +0800, Zhu, Peter J wrote:
> > -----Original Message-----
> > From: Ding, Jian-feng
> > Sent: Wednesday, July 28, 2010 8:12 PM
> > To: Zhu, Peter J; Xu, Martin
> > Cc: meego-commits at meego.com
> > Subject: Re: [meego-commits] 6042: Changes to Trunk:Testing/wpa_supplicant
> > 
> > On Wed, Jul 28, 2010 at 07:44:49PM +0800, Zhu, Peter J wrote:
> > > >  %build
> > > > +# >> build pre
> > > >  pushd wpa_supplicant
> > > > -  cp %{SOURCE1} ./.config
> > > > -  CFLAGS="${CFLAGS:-%optflags}" ; export CFLAGS ;
> > > > -  CXXFLAGS="${CXXFLAGS:-%optflags}" ; export CXXFLAGS ;
> > > > -  make %{_smp_mflags}
> > > > -popd
> > > > +cp %{SOURCE1} ./.config
> > > > +CFLAGS="${CFLAGS:-%optflags}" ; export CFLAGS ;
> > > > +CXXFLAGS="${CXXFLAGS:-%optflags}" ; export CXXFLAGS ;
> > > > +# << build pre
> > > >
> > > > +
> > > > +make %{?jobs:-j%jobs}
> > > > +
> > > > +# >> build post
> > > > +popd
> > > > +# << build post
> > > >  %install
> > > >  rm -rf %{buildroot}
> > > > +# >> install pre
> > > > +# << install pre
> > > > +
> > > Where is %make_install??
> > 
> > It will be better if the Makefile of this package can support `make install`
> > target.
> > Otherwise we need customized installation scripts, the common handling
> > method with spectacle is:
> >  1. set "Builder: none" (then no auto generated "make %{?jobs:-j%jobs}" too)
> >  2. insert "make %{?jobs:-j%jobs}" in proper place in "build post" closure
> > 
> > As this package, I recommend to move all build script from "build pre" to
> > "build post", if "builder" must be none.
> > 
> Yes, agree. But weird thing is that yaml directive for Builder is make but no %make_install is emitted
> 
Not so weird, I am sure Martin has removed them manually :)

> Peter