[MeeGo-dev] [Patch]Enable MRST accelerometer in Nokia Sensor Framework

[Rongas Timo]

>-----Original Message-----
>From: Zhang, Xing Z [mailto:xing.z.zhang at intel.com] 
>Sent: Thursday, July 22, 2010 9:04 AM
>To: Rongas Timo
>Cc: meego-dev at meego.com; Chang, Esmond; Lee, Daniel; 
>Skowronski, Philippe
>Subject: [Patch]Enable MRST accelerometer in Nokia Sensor Framework
>
>Hi Timo:
>	Here are patches enable my accelerometer in Nokia 
>sensor framework.
>	Two things I am thinking about:
>	1. Should we pass a parameter to specify which 
>configure file to use? So we can have different configures for 
>different distributions.

Command line options for sensord are currently being worked on. Setting the configuration is one of the options we planned to add (others would be disabling context-properties, setting the logger level etc). Any wishes? :)

>	2. virtual void processSample(int pathId, int fd) of 
>sysfsadaptor should be more flexible. Actually I have a 
>phidgets accelerometer doesn't play with
>	  any sysfs file or device file, I have to change 
>prototype of processSample to make it work.

Looking at the patches I don't see the issue. What kind of additional flexibility would you like to see? 

As long as you have any "filekind" of handle, SysfsAdaptor basically does nothing but keeps it open for you and pings you to read it when appropriate (interrupt by epoll_wait or given interval). If you don't have a file, then you should just skip using SysfsAdaptor and implement DeviceAdaptor directly. 

That said, SysfsAdaptor does contain stuff that should be generalized to DeviceAdaptor in order to allow one to use that in a reasonable way. :)

>Hi Guys (CCed):
>	The patches could be cited as an example for adding 
>your sensor in Nokia sensor framework.	

I also just dropped an example of an adaptor using sysfsAdaptor as the base to sensorfw/examples/. You can also have a look there if you're putting together new adaptors.

// Timo

-- 
Timo Rongas
Project Manager

Digia Plc
Hämeentie 135 A, FI-00350 HELSINKI, FINLAND
Email: timo.rongas at digia.com
Gsm: +358 50 344 1529 Fax: +358 40 307 4089
Visit us at: www.digia.com
------------------------------------------------------------------
PRIVACY AND CONFIDENTIALITY NOTICE
This message and any attachments are intended only for use by 
the named addressee and may contain privileged and/or 
confidential information. If you are not the named addressee 
you should not disseminate, copy or take any action in 
reliance on it. If you have received this message in error, 
please contact the sender immediately and delete the message 
and any attachments accompanying it. Digia Plc does not accept 
liability for any corruption, interception, amendment, 
tampering or viruses occurring to this message.
------------------------------------------------------------------