[Meego-kernel] [PATCH 5/5] replaced some defines w/ enums and made module parameters writable

[Gorby, Russ]

>
>> - *	An SPI transfer has completed. Process any received data
>> and kick off
>> + *	A SPI transfer has completed. Process any received data
>> and kick off
>
>The original is actually correct.
>

[Gorby, Russ] 
I guess that depends on how you pronounce "SPI" - "Ess Pee Eye" or "Spy"
I always think latter or the expanded acronym, but perhaps the former is canonical?

>
>> +/* modem reset state */
>> +enum ifx_mdm_reset_state {
>> +	MR_START,
>> +	MR_INPROGRESS,
>> +	MR_COMPLETE,
>> +};
>
>Odd to make them enum and then leave them other types.

But they are only being used as bit offset parameters to set_bit() and friends on mdm_reset_state which can't be a enum. Am I misunderstanding?

>
>Also the ifx_spi_state seems to be the bit offsets not the bits so the
>comment seems wrong ?
>

[Gorby, Russ] ah yes, for all of them