[Meego-kernel] [PATCH 03/12] ifx_spi: correct IRQ free on unload

Chris Leech Christopher.Leech at linux.intel.com
Fri Oct 1 16:02:11 PDT 2010


On 10/01/2010 11:27 AM, Gorby, Russ wrote:
>
> Fix a bug in the exit routine where the wrong IRQ was being released
>
> Signed-off-by: Russ Gorby<russ.gorby at intel.com>
> ---
>   drivers/serial/ifx6x60.c |   17 ++++++++++-------
>   1 files changed, 10 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/serial/ifx6x60.c b/drivers/serial/ifx6x60.c
> index 818603a..9476dc4 100644
> --- a/drivers/serial/ifx6x60.c
> +++ b/drivers/serial/ifx6x60.c
> @@ -1424,18 +1424,21 @@ static const struct spi_driver ifx_spi_driver = {
>   /* module exit point */
>   static void __exit ifx_spi_exit(void)
>   {
> +	struct ifx_spi_device *ifx_dev = saved_ifx_dev;
> +

Any ETA on getting rid of this saved_ifx_dev nonsense?  Maybe making 
remove work correctly instead of tearing down the device in exit?

That seems more important than the minor cleanups in this series.

- Chris



More information about the Meego-kernel mailing list