[Meego-kernel] [PATCH] Audio: Add ioctl interface for sending algorithm parameters

[Alan Cox]

On Fri, 8 Oct 2010 19:24:42 +0530
"Koul, Vinod" <vinod.koul at intel.com> wrote:

> Hi,
> 
> Below is the reworked patch for post processing interface,
> as suggested this is now an ioctl interface
> This patch needs to be applied on top of other audio patch series
> sent last week

Looking at this the one thing I don't get is why it needa a new
device ?

> +long intel_sst_ioctl_dsp(struct file *file_ptr, unsigned int cmd,
> +                                               unsigned long arg)
> +{
> +       int retval = 0;
> +       struct snd_ppp_params *algo_params;
> +       struct snd_ppp_params *algo_params_copied;
> +       struct ipc_post *msg;
> +
> +       lock_kernel();

Pleaase don't add lock/unlock_kernel to new code. It's in some old code
because it was implied by old ioctl handlers and has been put there
pending verifying it isn't needed.

Assuming your sst_xxx_algo() stuff isn internally locked I don't see a
need for them.


> +       default:
> +               pr_debug("sst: unknown ioctl recieved\n");

Some of the debug on this is excessive I think.

Alan