[Meego-kernel] [PATCH] New functions added to the LED Driver

[Arjan van de Ven]

  On 10/13/2010 7:16 PM, Tao, Jing wrote:
> Hi Alen, I have just corrected the issue, please have a look.
>
>  From 13320b7a18eab07e7009443bb730690fcb40dfe4 Mon Sep 17 00:00:00 2001
> From: Tao Jing<jing.tao at intel.com>
> Date: Wed, 13 Oct 2010 15:49:14 +0800
> Subject: [PATCH] New functions added to the LED Driver
>
> The Driver supports the following:
>
> --LED Mode Selection
> --Flash Time Adjust
> --Flash Current Adjust
> --Torch Current Adjust
> --Indicator Current Adjust
> --OSPM
> --Run-time PM

can you please create a better patch description?
this is not useful for anyone who wonders what is going on ;(
+

> +static int mfld_ledflash_set_ic(struct i2c_client *client, u8 value);
> +static int mfld_ledflash_set_voff(struct i2c_client *client, u8 value);
> +static int mfld_ledflash_set_flashtime(struct i2c_client *client, u8 value);
> +static int mfld_ledflash_set_flashcurrent(struct i2c_client *client, u8 value);
> +static int mfld_ledflash_set_diodedetection(struct i2c_client *client,
> +					    u8 value);
> +static int mfld_ledflash_set_assistlightcurrent(struct i2c_client *client,
> +						u8 value);
> +static int mfld_ledflash_set_inductorcurrentlimit(struct i2c_client *client,
> +						  u8 value);
> +static int mfld_ledflash_set_outputmode(struct i2c_client *client, u8 value);
> +static int mfld_ledflash_set_strobemode(struct i2c_client *client, u8 value);
> +static int mfld_ledflash_set_exttorch(struct i2c_client *client, u8 value);
> +static int mfld_ledflash_set_outputenable(struct i2c_client *client, u8 value);
> +static int mfld_ledflash_set_extstrobe(struct i2c_client *client, u8 value);

if you order your .c file correctly, you don't need these prototypes...
+static int set_reg(struct i2c_client *client, u8 reg, u8 mask, u8 value,+
> +	dev_dbg(&client->dev, "write reg:0x%x value:0x%x \n", reg, tmp);

this debug happens on EVERY write!
Please reserve debug prints only to places where something is going wrong ;(