[Meego-kernel] Staging: change i2c_ledflash name against FW update
Greg KH
gregkh
Mon Sep 27 12:25:41 PDT 2010
On Mon, Sep 27, 2010 at 11:43:32AM -0700, Arjan van de Ven wrote:
> On 9/27/2010 11:38 AM, Greg KH wrote:
>> On Mon, Sep 27, 2010 at 06:10:13PM +0100, Alan Cox wrote:
>>>>> static const struct i2c_device_id mfld_ledflash_id[] = {
>>>>> - {"i2c_cam_flash", 0},
>>>>> + {"i2c_ledflash", 0},
>>>>> {}
>>>> That's a pretty big userspace API change, are you sure no tools are
>>>> going to be broken when you do this?
>>>>
>>>> And why make this change at all? What does it matter?
>>> To match the firmware - its a staging driver and the firmware need can
>>> change. Once I've got the sfi patch upstream (need to poke Thomas and
>>> Ingo again) it'll get somewhat easier to manage these, especially as
>>> for many cases we end up translating from a "firmware name" into a
>>> linux device name which usually reflects the physical device vendor and
>>> identifier.
>> Ah, ok, that makes sense, thanks.
>>
>> Hm, but again, why are these being sent to the meego kernel list? Do
>> you think you might want to just have a new list for your MID tree, if
>> that's the real need here?
>
> the assumption from management is that these patches will also go into
> MeeGo at/around the same time.
Since when does some anonymous "management" mean anything to a community
mailing list?
Seriously, who do I have to talk to at Intel to rid them of this myth?
Please tell Intel and Nokia people to stop trying to use this mailing
list as an excuse from using the more relevant community kernel
subsystem mailing lists as a review/submission place.
thanks,
greg k-h
More information about the Meego-kernel
mailing list