[Meego-kernel] [PATCH 08/40] fix msg port read write error on medfield
Arjan van de Ven
Wed Sep 29 19:08:27 PDT 2010
this patch has no description...
but code like
+static inline void MDFLD_MSG_WRITE32(uint port, uint offset, u32 value)
+ int mcr = (0x11<<24) | (port << 16) | (offset << 8) | 0xF0;
+ outl(0x800000D4, 0xCF8);
+ outl(value, 0xcfc);
+ outl(0x800000D0, 0xCF8);
+ outl(mcr, 0xCFC);
is totally and utterly unacceptable.
Hand poking of the PCI registers like this from drivers is an absolute
no-go; your code does not take the PCI lock that protects against other
people using port CF8 as well concurrently.
there is no way I can accept this patch; this is a data corruptor.
More information about the Meego-kernel