[Meego-kernel] [PATCH 19/40] Avoid using some TTM interfaces directly for buildin

[Yuan, Shengquan]

Agree. We will fix it.

-----Original Message-----
From: Arjan van de Ven [mailto:arjan at linux.intel.com] 
Sent: Wednesday, September 29, 2010 7:30 PM
To: Patel, Hitesh K
Cc: meego-kernel at meego.com; Kuo, Chia-hung S; Dou, Justin; Mai, Leonard
Subject: Re: [Meego-kernel] [PATCH 19/40] Avoid using some TTM interfaces directly for buildin

  +static void psb_ttm_bo_free_old_node(struct ttm_buffer_object *bo)
+{
+    struct ttm_mem_reg *old_mem = &bo->mem;
+
+    if (old_mem->mm_node) {
+        spin_lock(&bo->glob->lru_lock);
+        drm_mm_put_block(old_mem->mm_node);
+        spin_unlock(&bo->glob->lru_lock);
+    }
+    old_mem->mm_node = NULL;
+}

duplicating existing functions like this sounds like making an 
unmaintainable mess for the driver

I don't think you really want to do that. Really.