[Meego-kernel] [PATCH 1/9] intel_mid_keypad: remove hardcode of matrix and debounce

[Alan Cox]

On Tue,  1 Feb 2011 16:04:14 -0800
Kristen Carlson Accardi <kristen at linux.intel.com> wrote:

> Right now the driver programs the number of matrix rows, cols,
> debounce interval, direct key nums and rotary info.  This
> information is passed into the driver from pdata, a new platform
> data structure.  This information should really be programmed
> into the KPC register by firmware, and then read by the driver
> via the pci shim layer.  This patch removes this info from
> the pdata structure and implements the code to read this info from
> the KPC register.  Because firmware doesn't actually behave the
> way it should right now, this patch creates a pci quirk for the
> langwell keypad which programs the KPC register.

Makes sense conceptually - but please document the magic numbers in use.