[Meego-kernel] [PATCH RFC] platform/oaktrail: ACPI EC Extra driver for Oaktrail
alan at linux.intel.com
Wed Feb 23 07:50:19 PST 2011
On Wed, 23 Feb 2011 09:49:08 +0800
Yin Kangkai <kangkai.yin at linux.intel.com> wrote:
> Thanks for the review Alan.
> On 2011-02-22, 17:27 +0000, Alan Cox wrote:
> > > 1. exports 2 platform device attributes files in
> > > /sys/devices/platform/intel_oaktrail/:
> > > camera - Camera subsystem enabled: contains either 0 or 1. (rw)
> > > touchscreen - Touchscreen subsystem enabled: contains either 0
> > > or 1. (ro)
> > Is there a reason to expose these this way rather than just enabling
> > them when the user opens the device ?
> The reason I can think of is: this is oaktrail platform specific
> Code sitting here seems more reasonable, comparing to the way we
> provide interfaces for Camera driver to invoke when opened. Make
I would expect the driver to just work. Think about it from the
application point of view - why should applications need to know about
magic oaktrail sysfs interfaces ?
It may be useful to provide them but opening a device would normally
automatically manage power and configuration for it.
More information about the MeeGo-kernel