[Meego-kernel] [PATCH] ar6003 : Can't set key with (GROUP_USAGE | TX_USAGE) for WPA/WPA2

[Samuel Ortiz]

Hi Samuel,

My comments below:

On Wed, Jun 15, 2011 at 06:37:08PM +0000, Chang, Samuel wrote:
> Subject: Can't set key with (GROUP_USAGE | TX_USAGE) for WPA/WPA2
>          1. Remove checking in ar6k_cfg80211_connect(), it already checks for None AUth. (NONE_AUTH == arPriv->arAuthMode)
>
So this part is more of a cleanup than anything else, right ?


>          2. Add checking in ar6k_cfg80211_set_default_key().  WPA/WPA2 can't set key with (GROUP_USAGE | TX_USAGE)
> 
That seems weird. So you would only be able to set default keys for WEP ?


>           Without this patch, wifi firmware state machine may go wrong.
Can you elaborate on that ? What would be the consequences on the host
operations ?

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/