[Meego-kernel] [patch] mrstov5640: use linux debug print mechanism #9826

Arjan van de Ven arjan at linux.intel.com
Sun Jun 19 22:00:56 PDT 2011


On 6/19/2011 8:39 PM, He, Yong M wrote:
> @@ -1126,7 +1126,10 @@
>   		} else {
>   			spin_unlock_irqrestore(
>   					&ov5640_status.state_lock, flags);
> -			dprintk(3, "[ov5640-wr-reg]<----------- same res index-%d (%dx%d)", target_res_index,width, height);
> +			dev_dbg(sd->v4l2_dev->dev,
> +					"[ov5640-wr-reg]<----------- "
> +					"same res index-%d (%dx%d)",
> +					target_res_index, width, height);
>   		}
>


looks good; one comment... there's no need to split strings or even 
print lines like this, even if checkpatch.pl complains...checkpatch is 
not perfect in this regard.



More information about the MeeGo-kernel mailing list