[Meego-kernel] [RFC/PATCH] langwell_otg: runtime pm support

[Major_Lee at wistron.com]

Hi, Hao

I removed pmic_battery_set_charger() in intel_mid_battery, the battery
driver, for our design.
SCU firmware will take care about battery charging/discharging.

In langwell_otg, langwell_otg_chrg_vbus() changes the value of OTG
status control register.
I never change the code of  langwell_otg_chrg_vbus(), and it is works
for me.
But I am curious about the comment of langwell_otg_chrg_vbus()
  /* charge vbus or discharge vbus through a resistor to ground */

Thank you.

Sincerely,
Major Lee


 

> -----Original Message-----
> From: Wu, Hao [mailto:hao.wu at intel.com] 
> Sent: Wednesday, March 16, 2011 12:37 PM
> To: Major Lee/WHQ/Wistron; alan at linux.intel.com
> Cc: meego-kernel at meego.com
> Subject: RE: [Meego-kernel] [RFC/PATCH] langwell_otg: runtime 
> pm support
> 
> >Hi, Alan
> >
> >For hardware design of the platform which in my hand, there is no
> >charging by USB.
> >Should I empty the code of langwell_otg_chrg_vbus() when there is
> >charging by AC only?
> 
> Hi Lee,
> 
> Actually, Langwell_otg driver will not handle the charging 
> related work. Battery driver owns the charging functionalities.
> Ideally the function langwell_otg_chrg_vbus() will not impact 
> anything if no battery attached.
> I don't know if any specific design with your hardware 
> platform, but I think you can keep them and have a try.
> 
> Both AC/Battery mode works well with the same USB code as my 
> experience.
> 
> Hao
>