[meego-packaging] File inclusion depending on image type

[Luis Araujo]

On 04/21/2011 08:02 AM, Marko Saukko wrote:
> On 04/21/2011 02:42 PM, Luis Araujo wrote:
>> On 04/21/2011 06:11 AM, Marko Saukko wrote:
>>> On 04/21/2011 01:16 PM, Luis Araujo wrote:
>>>> On 04/21/2011 02:16 AM, Marko Saukko wrote:
>>>> How exactly do we go adding this package to that pattern?
>>>
>> Thanks for the detailed explanation Marko, .... now to clear up a few
>> doubts ...
>>
>>> Adding package to the group is quite easy. You need to submit patch to
>>> package-groups git tree and to "nokia-n900-support" pattern.
>>>
>>> https://meego.gitorious.org/meego-os-base/package-groups/blobs/master/patterns/meego-nokia-n900-support.xml 
>>>
>>>
>>>
>>> However, it is not so simple if the packages conflict between the
>>> default style and n900 style. Lets assume for this example that we
>>> have vkb-style-default and vkb-style-n900 packages. By default the
>>> vkb-style-default is installed in package group X or by dependency of
>>> some package in package group Y, now when mic sees that it puts the
>>> package vkb-style-default to the installed packages list. After it
>>> gets to the nokia-n900-support group it sees the vkb-style-n900
>>> package which is also put to the installation list which now causes
>>> conflict with the packages and image creation fails.
>>>
>> When you say "conflict with the packages", you mean a file collision
>> problem? ...
>
> Yes, I mean the problem where two packages provide the same files.
>
>>
>> The thing is, the meegotouch themes kind of work in a incremental way,
>> if it finds a theme other than the default style, it will use that one;
>> we can actually have vkb-style-default and vkb-style-n900 installed in
>> the same system without any problem, both style files would be installed
>> in different locations, in fact, this would probably be the right way to
>> do it.
>
> Ok, this sounds nice. And if it is true then there should not be much 
> problems with this (also my worries about editing multiple patterns 
> can be forgotten). Still couple of questions: how to define which 
> style from the all it uses? Is it the /meegotouch/theme/name gconf key?
Correct using the gconf key.


>
> AFAIK there is the base theme in meegotouch that is used if the 
> element is not found in the theme describe with the gconf key 
> mentioned above. Is it possible to do chain of themes e.g., 
> base->theme A->theme B. Meaning that first check if the needed theme 
> is in B and then A and as last resort use base?
>
Correct, this is the way it works, currently the N900 is: theme->base , 
theme->meego ...... meaning that it first checks meego, and if it is not 
found there, it checks base ; so we can keep the default style in the 
base/ path and the n900 style in the meego/ directory (already tested 
and it works).


>>
>>> If vkb package would require vkb-style package for example and there
>>> would be vkb-style-default and vkb-style-n900 package that both
>>> provide the vkb-style the image creation could not decide if neither
>>> one of these are implicitly defined to be installed.
>> Right, as I stated above, we could have both style packages installed in
>> the same system.
>
> ok
>
>>
>>>
>>> What I mean with this if we would have vkb-style-n900 and
>>> vkb-style-default packages in the MeeGo core repository we would also
>>> need to define which style to use in every image configuration not
>>> only N900, which requires change to multiple package groups instead of
>>> the n900 one only. So you might need to change
>>> "meego-moorestown-support", "meego-oaktrail-support" etc groups as
>>> well so that they would prefer the default.
>>>
>> So if I get this right, could we just add vkb-default-style to the MeeGo
>> core repository, and if we need to add any custom style, just add that
>> package to the specific pattern? .... In this case vkb-style-n900 will
>> be installed along the vkb-style-default package in the N900 image, and
>> the rest of the images can just keep using vkb-style-default?
>>
>> By the way, we could also keep the default CSS style file in the VKB
>> package, so all platforms will get the default style, and we just
>> overwrite this style with the different pattern style packages when
>> needed ... would this be simpler?
>>
>
> If the theme can be overridden with other theme by just some gconf key 
> or similar then the default theme should be in VBK package and we 
> should only add the vkb-style-n900 package or what ever it would be 
> called. It is always good to have some failsafe option in the default 
> package for users that do not have customized themes ready.
>
Perfect, I think this would be simpler; then I guess we can do this :)

Regards,
> Regards,
> Marko