[meego-packaging] [meego-commits] 13240: Changes to Trunk:Testing/ofono

[Ryan Ware]

On 2/2/11 9:34 AM, "Anas Nashif" <nashif at linux.intel.com> wrote:

>
>On 2 Feb 2011, at 16:55, Rolla Selbak wrote:
>
>> Hi,
>> I have made the following changes to ofono in project Trunk:Testing.
>>Please review and accept ASAP.
>> 
>> Thank You,
>> Rolla Selbak
>> 
>> [This message was auto-generated]
>> 
>> ---
>> 
>> Request #13240:
>> 
>>  submit:   devel:connectivity/ofono(r4) -> Trunk:Testing/ofono
>> 
>> 
>> Message:
>>    * Thu Jan 27 2011 Jouni Peltonen <jouni.peltonen at cybercom.com> - 0.39
>> - Fixes BMC#12559.
>> - 0001-isimodem-Fix-race-condition-in-SIM-probe.patch upstream commit:
>>9306837053cd6ce35e0fe02f03c3cd0eba443f6c.
>> - 0002-n900-Fix-online.patch upstream commit:
>>f6f0f4d12116cbf8787928146b3b97df21acb739 (forwarded request 12917 from
>>jouni.peltonen)
>> 
>> State:   new          2011-02-02T08:54:52 rolla
>> Comment: None
>> 
>> 
>> 
>> changes files:
>> --------------
>> --- ofono.changes
>> +++ ofono.changes
>> @@ -0,0 +1,5 @@
>> +* Thu Jan 27 2011 Jouni Peltonen <jouni.peltonen at cybercom.com> - 0.39
>> +- Fixes BMC#12559.
>> +- 0001-isimodem-Fix-race-condition-in-SIM-probe.patch upstream commit:
>>9306837053cd6ce35e0fe02f03c3cd0eba443f6c.
>> +- 0002-n900-Fix-online.patch upstream commit:
>>f6f0f4d12116cbf8787928146b3b97df21acb739
>> +
>This type of logs is really useless and does not tell me anything, can we
>agree to speak english in change logs and not in file names?

I'd like to second Anas' concern here.  We need to follow good
documentation practices here.  The package maintainer shouldn't have to
spend an exorbitant amount of time on the documentation, but there needs
to be much more information in the changelog than just the patch names and
their commit hashes.

Ryan