[MeeGo-touch-dev] Fixing API of MPannableViewport - behavioral break needed.

[ext-jarno.malmari at nokia.com]

MpannableViewport::setRange() is still misbehaving wrt. below changes. There is already a fix pending for that.

> -----Original Message-----
> From: meego-touch-dev-bounces at meego.com [mailto:meego-touch-dev-
> bounces at meego.com] On Behalf Of ext Michal Guminiak
> Sent: 8. marraskuuta 2010 14:45
> To: MeeGo Touch Framework Development (discussion list)
> Subject: Re: [MeeGo-touch-dev] Fixing API of MPannableViewport -
> behavioral break needed.
> 
> Hello,
> 
> This is a reminder message:
> 
> Dnia 2010-08-11, śro o godzinie 11:29 +0200, Michal Guminiak pisze:
> > Hi,
> >
> > I'm planning to make two behavioral breaks in MPannable* classes to
> > fix two problems. Both about redefinition of the meaning of inherited
> > methods, which blatantly breaks the concept of class inheritance.
> >
> > First change
> > ============
> >
> > Current state:
> >   MPannableWidget::range()   - range of valid/possible values for
> > position()
> >   MPannableViewport::range() - Area of widget() that can be made
> > visible in
> >                                the viewport by panning. Equal to size
> > of
> >                                the panned widget.
> > Target state:
> >   MPannableWidget::range()   - range of valid/possible values for
> > position()
> >   MPannableViewport::range() - range of valid/possible values for
> > position()
> >
> >
> > Second change
> > =============
> >
> > Current state:
> >   QGraphicsItem::setEnabled()   - Disabled items are visible, but
> they
> > do not receive
> >                                   any events, and cannot take focus
> > nor be selected.
> >                                   Disabled items are traditionally
> > drawn using
> >                                   grayed-out colors
> >   MPannableWidget::setEnabled() - whether panning is enabled
> >
> > Target state:
> >   QGraphicsItem::setEnabled()   - Disabled items are visible, but
> they
> > do not receive
> >                                   any events, and cannot take focus
> > nor be selected.
> >                                   Disabled items are traditionally
> > drawn using
> >                                   grayed-out colors
> >   MPannableWidget::setEnabled() - Disabled items are visible, but
> they
> > do not receive
> >                                   any events, and cannot take focus
> > nor be selected.
> >                                   Disabled items are traditionally
> > drawn using
> >                                   grayed-out colors
> >   MPannableWidget::setPanningEnabled() - whether panning is enabled
> >
> > The patch will require some apps to change their code but the change
> > is trivial and even if they don't change, nothing drastic such as
> > crashes should occur.
> >
> > If anybody has any concerns about that and would rather not see me
> > doing it, please speak up!
> >
> 
> The changes described in this mail have been recently integrated, with
> one exception. The MPannableWidget::setPanningEnabled() method was not
> introduced, please instead use set MPannableWidget::setPanDirection(0);
> 
> Please also note, that there are new methods added to the
> MPannableWidget API, which allows setting panning policy
> setHorizontalPanningPolicy() and setVerticalPanningPolicy().
> 
> BR,
> Michał.
> _______________________________________________
> MeeGo-touch-dev mailing list
> MeeGo-touch-dev at meego.com
> http://lists.meego.com/listinfo/meego-touch-dev